dramaticlly commented on code in PR #12228:
URL: https://github.com/apache/iceberg/pull/12228#discussion_r2364430805
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -299,6 +309,14 @@ protected MetricsReporter metricsReporter() {
return metricsReporter;
}
+ // Atomically set given metadata as current
+ protected void setAsCurrent(
Review Comment:
Removed `base` from `setAsCurrent`. Originally I added this to use for
lock-free version of AlterTable in HiveCatalog as base is not used in JDBC or
InMemory catalog at all. I think it's better to keep the interface clean and
general to all catalogs instead of considering implementation as the constraint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
