wgtmac commented on code in PR #482:
URL: https://github.com/apache/iceberg-cpp/pull/482#discussion_r2661875679
##########
src/iceberg/catalog/rest/resource_paths.h:
##########
@@ -44,11 +43,8 @@ class ICEBERG_REST_EXPORT ResourcePaths {
static Result<std::unique_ptr<ResourcePaths>> Make(std::string base_uri,
const std::string&
prefix);
- /// \brief Set the base URI of the REST catalog server.
- Status SetBaseUri(const std::string& base_uri);
-
/// \brief Get the /v1/config endpoint path.
- Result<std::string> Config() const;
+ static Result<std::string> Config(const std::string& base_uri);
Review Comment:
It sounds good to remove `SetBaseUri`. However, it leads to confusion to
make this a static function. I'd suggest revert this function as you have
created a new ResourcePaths based on the server config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
