wgtmac commented on code in PR #482: URL: https://github.com/apache/iceberg-cpp/pull/482#discussion_r2661880429
########## src/iceberg/catalog/rest/rest_catalog.cc: ########## @@ -132,7 +132,11 @@ Result<std::shared_ptr<RestCatalog>> RestCatalog::Make( // Update resource paths based on the final config ICEBERG_ASSIGN_OR_RAISE(auto final_uri, final_config->Uri()); - ICEBERG_RETURN_UNEXPECTED(paths->SetBaseUri(std::string(TrimTrailingSlash(final_uri)))); + ICEBERG_ASSIGN_OR_RAISE( Review Comment: I think it is cheap to create a new ResourcePaths. I'm fine with this change and please revert changes from 113 to 115 above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
