danielcweeks commented on code in PR #14979:
URL: https://github.com/apache/iceberg/pull/14979#discussion_r2669025346
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java:
##########
@@ -67,7 +69,15 @@ RecordWriter createWriter(String tableName, SinkRecord
sample, boolean ignoreMis
}
}
- return new IcebergWriter(table, tableName, config);
+ UUID tableUuid = table.uuid();
+ if (tableUuid == null) {
Review Comment:
Yes, this is due to the spec stating that the `table-uuid` is optional in
v1. It's safer to just account for it being null than assuming we don't have
older tables or other implementations that do not have a uuid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
