bryanck commented on code in PR #14979:
URL: https://github.com/apache/iceberg/pull/14979#discussion_r2669141979
##########
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/TableReference.java:
##########
@@ -73,10 +96,25 @@ public TableReference(String catalog, List<String>
namespace, String name) {
this.avroSchema = AVRO_SCHEMA;
}
+ private TableReference(String catalog, List<String> namespace, String name,
UUID uuid) {
+ Preconditions.checkNotNull(catalog, "Catalog cannot be null");
+ Preconditions.checkNotNull(namespace, "Namespace cannot be null");
+ Preconditions.checkNotNull(name, "Name cannot be null");
Review Comment:
Maybe add a TODO comment to add a null check for UUID in 1.12
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java:
##########
@@ -67,7 +69,15 @@ RecordWriter createWriter(String tableName, SinkRecord
sample, boolean ignoreMis
}
}
- return new IcebergWriter(table, tableName, config);
+ UUID tableUuid = table.uuid();
+ if (tableUuid == null) {
Review Comment:
Maybe add another TODO comment for 1.12?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
