aiborodin commented on code in PR #14810:
URL: https://github.com/apache/iceberg/pull/14810#discussion_r2674331992
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommittableSerializer.java:
##########
@@ -46,26 +47,61 @@ public byte[] serialize(DynamicCommittable committable)
throws IOException {
view.writeUTF(committable.jobId());
view.writeUTF(committable.operatorId());
view.writeLong(committable.checkpointId());
- view.writeInt(committable.manifest().length);
- view.write(committable.manifest());
+
+ int numManifests = committable.manifests().length;
+ view.writeInt(numManifests);
+ for (int i = 0; i < numManifests; i++) {
+ byte[] manifest = committable.manifests()[i];
+ view.writeInt(manifest.length);
+ view.write(manifest);
+ }
+
return out.toByteArray();
}
@Override
public DynamicCommittable deserialize(int version, byte[] serialized) throws
IOException {
- if (version == 1) {
- DataInputDeserializer view = new DataInputDeserializer(serialized);
- WriteTarget key = WriteTarget.deserializeFrom(view);
- String jobId = view.readUTF();
- String operatorId = view.readUTF();
- long checkpointId = view.readLong();
- int manifestLen = view.readInt();
- byte[] manifestBuf;
- manifestBuf = new byte[manifestLen];
- view.read(manifestBuf);
- return new DynamicCommittable(key, manifestBuf, jobId, operatorId,
checkpointId);
+ if (version == VERSION_1) {
+ return deserializeV1(serialized);
+ } else if (version == VERSION_2) {
+ return deserializeV2(serialized);
}
throw new IOException("Unrecognized version or corrupt state: " + version);
}
+
+ private DynamicCommittable deserializeV1(byte[] serialized) throws
IOException {
+ DataInputDeserializer view = new DataInputDeserializer(serialized);
+ WriteTarget key = WriteTarget.deserializeFrom(view);
+ String jobId = view.readUTF();
+ String operatorId = view.readUTF();
+ long checkpointId = view.readLong();
+ int manifestLen = view.readInt();
+ byte[] manifestBuf;
+ manifestBuf = new byte[manifestLen];
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
