amogh-jahagirdar commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2680762445
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestPositionDeletesTable.java:
##########
@@ -455,7 +455,7 @@ public void testPartitionTransformFilter() throws
IOException {
Pair<List<PositionDelete<?>>, DeleteFile> deletesA =
deleteFile(tab, dataFileA, new Object[] {"aa"}, new Object[] {"a"});
Pair<List<PositionDelete<?>>, DeleteFile> deletesB =
- deleteFile(tab, dataFileA, new Object[] {"bb"}, new Object[] {"b"});
Review Comment:
This fix surfaced an issue in some of the TestPositionDeletesTable tests
where we were adding the wrong data file; we'd just add a DV for the same data
file, and then it'd get merged with the new logic , and break some of the later
assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
