amogh-jahagirdar commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2700200795
##########
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##########
@@ -71,6 +71,17 @@ public void delete(String path, long pos, PartitionSpec
spec, StructLike partiti
positions.delete(pos);
}
+ @Override
+ public void delete(
Review Comment:
I'm double checking if we really need this. The DVFileWriter has some level
of state tracking within it and we may be able to just leverage those cleanly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
