amogh-jahagirdar commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2700269939
##########
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##########
@@ -71,6 +71,17 @@ public void delete(String path, long pos, PartitionSpec
spec, StructLike partiti
positions.delete(pos);
}
+ @Override
+ public void delete(
Review Comment:
I remember why I did it this way, so alternatively after merging the
position delete index we could just iterate over each position in the bitmap
and call the existing delete API, but that felt worse than just adding an API
which leverages the fact that bitmaps could do bulk merges. That being said,
I'm not currently leveraging the fact that the writer itself merges the indices
for a given path.
Alternatively we could intialize the writer, iterate over <referenced file,
duplicate set>, and load every duplicate into a position index, validate all
the stuff we're validating right now, and then call this new delete. That feels
less reliable, not a fan of having an open file writer, and then doing more I/O
while it's open, so this 2 phased merge and write seems better to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
