amogh-jahagirdar commented on code in PR #15051:
URL: https://github.com/apache/iceberg/pull/15051#discussion_r2706717221
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -169,7 +169,7 @@ public void commit(TableMetadata base, TableMetadata
metadata) {
.addAll(metadata.changes())
.build();
requirements = UpdateRequirements.forCreateTable(updates);
- errorHandler = ErrorHandlers.tableErrorHandler(); // throws
NoSuchTableException
+ errorHandler = ErrorHandlers.tableCommitHandler(); // throws
NoSuchTableException
Review Comment:
Yeah I think we may just want to add a createTableErrorHandler() which
extends the commit error handler, but we override the 409 behavior to be a
TableAlreadyExists exception, and then in any other case fallback to
super.accept(error).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
