emkornfield commented on code in PR #1876:
URL: https://github.com/apache/iceberg-rust/pull/1876#discussion_r2709829947
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -461,9 +463,58 @@ impl TableMetadata {
file_io: &FileIO,
metadata_location: impl AsRef<str>,
) -> Result<()> {
+ let json_data = serde_json::to_vec(self)?;
+
+ // Check if compression is enabled via table properties
+ let codec = self
+ .properties
+ .get(TableProperties::PROPERTY_METADATA_COMPRESSION_CODEC)
Review Comment:
I agree, it seems like:
1. Someone is already working on that.
2. This increases the scope significantly.
Given these, could we decouple that change from this (for now I've made a
helper method and used it for parsing here and on TableProperties).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
