liurenjie1024 commented on code in PR #1876:
URL: https://github.com/apache/iceberg-rust/pull/1876#discussion_r2715008725
##########
crates/iceberg/src/spec/table_properties.rs:
##########
@@ -49,10 +56,70 @@ pub struct TableProperties {
pub write_format_default: String,
/// The target file size for files.
pub write_target_file_size_bytes: usize,
+ /// Compression codec for metadata files (JSON), None means no compression
+ pub metadata_compression_codec: Option<MetadataCompressionCodec>,
/// Whether to use `FanoutWriter` for partitioned tables.
pub write_datafusion_fanout_enabled: bool,
}
+/// Compression codec for metadata files (JSON).
+#[derive(Debug, PartialEq)]
+pub enum MetadataCompressionCodec {
Review Comment:
I have concerns with this approach. OSS software is somehow different
enterprise software development. If everyone just move forward with a lot of
diverges and left the cleanup things to others, the codebase will become a
mess. I think a better approach would be to have another pr to move the
compression codec enum into spec module. And then we can move on with this pr
after it got merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
