RussellSpitzer commented on code in PR #14297:
URL: https://github.com/apache/iceberg/pull/14297#discussion_r2733478311


##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java:
##########
@@ -255,6 +280,22 @@ private void startRowGroup() {
   public void close() throws IOException {
     if (!closed) {
       this.closed = true;
+
+      // Force initialization if lazy writer still has buffered data
+      if (model instanceof WriterLazyInitializable lazy) {

Review Comment:
   This is a little confusing to me, this is for the case in which our model 
has buffered but not yet put the information in to a row group? IE we are still 
deciding how to shred or something like that but close has been called?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to