RussellSpitzer commented on code in PR #14297:
URL: https://github.com/apache/iceberg/pull/14297#discussion_r2733500221


##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java:
##########
@@ -134,6 +134,31 @@ private void ensureWriterInitialized() {
 
   @Override
   public void add(T value) {
+    if (model instanceof WriterLazyInitializable lazy) {

Review Comment:
   Another possibility, can we create the ParquetWriter after buffering? The 
timeline now just seems a little odd
   
   Make Writer, Start buffering data, InitWriter
   
   I haven't walked through this but I would have thought we would do something 
like
   
   Buffer Data, Make Writer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to