ferhatelmas commented on code in PR #702:
URL: https://github.com/apache/iceberg-go/pull/702#discussion_r2737358113
##########
table/rolling_data_writer.go:
##########
@@ -157,12 +162,15 @@ func (r *RollingDataWriter) flushToDataFile(batch
[]arrow.RecordBatch, outputDat
task := iter.Seq[WriteTask](func(yield func(WriteTask) bool) {
cnt := int(r.factory.counter.Add(1) - 1)
+ fileCount := int(r.fileCount.Add(1))
yield(WriteTask{
- Uuid: *r.factory.args.writeUUID,
- ID: cnt,
- Schema: r.factory.taskSchema,
- Batches: batch,
+ Uuid: *r.factory.args.writeUUID,
+ ID: cnt,
Review Comment:
nit: not exactly related to this PR but isn't `cnt` supposed to initialize
by the given `args.counter` as in unpartitioned case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
