ferhatelmas commented on code in PR #702:
URL: https://github.com/apache/iceberg-go/pull/702#discussion_r2737378758
##########
table/arrow_utils.go:
##########
@@ -1338,13 +1338,17 @@ func recordsToDataFiles(ctx context.Context,
rootLocation string, meta *Metadata
tasks := func(yield func(WriteTask) bool) {
defer stopCount()
+ fileCount := 0
for batch := range binPackRecords(args.itr, 20,
targetFileSize) {
cnt, _ := nextCount()
+ fileCount++
t := WriteTask{
- Uuid: *args.writeUUID,
- ID: cnt,
- Schema: taskSchema,
- Batches: batch,
+ Uuid: *args.writeUUID,
+ ID: cnt,
+ PartitionID: 0, // unpartitioned tables
use 0
Review Comment:
does it make sense to use unpartitioned spec id directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
