nastra commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2745080710
##########
bigquery/src/test/java/org/apache/iceberg/gcp/bigquery/TestBigQueryCatalog.java:
##########
@@ -169,6 +170,18 @@ public void testRenameTableMissingSourceTable() {
super.testRenameTableMissingSourceTable();
}
+ @Disabled("BigQuery Metastore does not support rename tables")
+ @Test
+ public void testCreateTableInUniqueLocation() {
+ super.testCreateTableInUniqueLocation();
+ }
+
+ @Disabled("BigQuery Metastore does not support rename tables")
+ @Test
+ public void testDropDoesntCorruptTable() throws IOException {
+ super.testDropDoesntCorruptTable();
+ }
+
Review Comment:
yeah let's remove `supportsTableRename()` for now and just override failing
tests in `TestBigQueryCatalog`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
