nastra commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2745117788
##########
open-api/src/test/java/org/apache/iceberg/rest/RESTCompatibilityKitCatalogTests.java:
##########
@@ -97,4 +97,9 @@ protected boolean supportsNamesWithDot() {
return PropertyUtil.propertyAsBoolean(
restCatalog.properties(),
RESTCompatibilityKitSuite.RCK_SUPPORTS_NAMES_WITH_DOT, false);
}
+
+ @Override
+ protected boolean supportsUniqueTableLocation() {
+ return false;
Review Comment:
so the original issue that was flagged I believe is that
`UNIQUE_TABLE_LOCATION` was set to true by default for all tests, which is a
behavioral change. We don't want to set this by default. Instead, we only want
to set it in the respective tests that verify unique table location behavior,
which you are already doing in the new tests you added to `CatalogTests`.
My expectation is actually that `TestRESTCatalog` would work with the new
tests you added as well. However, I think the reason why they don't currently
work with `TestRESTCatalog` is because the flag isn't fully passed through to
the `backendCatalog` that is used by the REST catalog.
Does that make sense? So you'd need to make sure that the
`UNIQUE_TABLE_LOCATION` flag is passed through to the underlying/backend
catalog, which in the case of `TestRESTCatalog` is the `InMemoryCatalog`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
