adutra commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2746768347
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1249,6 +1249,41 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/namespaces/{namespace}/tables/{table}/sign/{provider}:
Review Comment:
Thanks for the example! If I get the suggestion right, you are proposing to
add a new field to `RemoteSignRequest`:
```yaml
RemoteSignRequest:
description: The request to be signed remotely.
type: object
required:
- provider
- region
- uri
- method
- headers
properties:
provider: # NEW FIELD
type: string
region:
type: string
uri:
type: string
method:
type: string
enum: ["PUT", "GET", "HEAD", "POST", "DELETE", "PATCH", "OPTIONS"]
# etc.
```
The problem with this approach is that it's not backwards-compatible. An
older client wouldn't know anything about this new field and wouldn't include
it in the request body, which would make a newer server reject the request.
We _could_ make this field optional and default to `s3` if not provided.
@nastra wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
