adutra commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2746905950
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -194,8 +227,36 @@ private boolean credentialProvided() {
@Value.Check
protected void check() {
Preconditions.checkArgument(
- properties().containsKey(S3_SIGNER_URI) ||
properties().containsKey(CatalogProperties.URI),
+ properties().containsKey(S3_SIGNER_URI)
+ || properties().containsKey(RESTCatalogProperties.SIGNER_URI)
Review Comment:
But the error is only thrown when _all of these props_ are missing. So the
existing test is imho already testing sufficiently. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
