huaxingao commented on code in PR #15217:
URL: https://github.com/apache/iceberg/pull/15217#discussion_r2755780773
##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -321,6 +321,11 @@ public Builder withSortOrder(SortOrder newSortOrder) {
return this;
}
+ public Builder withSortOrderId(int newSortOrderId) {
+ this.sortOrderId = newSortOrderId;
+ return this;
Review Comment:
if a caller uses both `withSortOrder` and `withSortOrderId` and the IDs
differ, could that mislead planning or optimizations that rely on sortOrderId?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
