raunaqmorarka commented on code in PR #15217:
URL: https://github.com/apache/iceberg/pull/15217#discussion_r2757174332
##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -321,6 +321,11 @@ public Builder withSortOrder(SortOrder newSortOrder) {
return this;
}
+ public Builder withSortOrderId(int newSortOrderId) {
+ this.sortOrderId = newSortOrderId;
+ return this;
Review Comment:
The expectation is that with either API, the input should be the correct
one. It would be a bug in the caller if either API were given the wrong input.
If there is still concern about this, then may be I can mark
`org.apache.iceberg.DataFiles.Builder#withSortOrder` as deprecated to encourage
callers to just use `withSortOrderId` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
