zeroshade commented on code in PR #702:
URL: https://github.com/apache/iceberg-go/pull/702#discussion_r2771234001
##########
table/rolling_data_writer.go:
##########
@@ -156,13 +166,16 @@ func (r *RollingDataWriter) flushToDataFile(batch
[]arrow.RecordBatch, outputDat
}
task := iter.Seq[WriteTask](func(yield func(WriteTask) bool) {
- cnt := int(r.factory.counter.Add(1) - 1)
+ cnt, _ := r.factory.nextCount()
Review Comment:
we made sure the base counter is safe for concurrent use, so I think this
should be fine as long as we make sure that `args.counter` is defined as having
to be safe for concurrent use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
