SYaoJun commented on code in PR #555:
URL: https://github.com/apache/iceberg-cpp/pull/555#discussion_r2772687331
##########
src/iceberg/util/lazy.h:
##########
@@ -38,10 +38,10 @@ class Lazy {
template <typename R, typename... Args>
struct Trait<R (*)(Args...)> {
- using ReturnType = R::value_type;
+ using ReturnType = typename R::value_type;
Review Comment:
Yes, clang-tidy suggest that. I think it is more straightforward if added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
