HuaHuaY commented on code in PR #555:
URL: https://github.com/apache/iceberg-cpp/pull/555#discussion_r2772737832
##########
src/iceberg/util/lazy.h:
##########
@@ -38,10 +38,10 @@ class Lazy {
template <typename R, typename... Args>
struct Trait<R (*)(Args...)> {
- using ReturnType = R::value_type;
+ using ReturnType = typename R::value_type;
Review Comment:
According to
cppreference(https://en.cppreference.com/w/cpp/language/dependent_name.html),
`a dependent qualified name is assumed to name a type and no typename is
required` when `a qualified name that appears in type-id, where the smallest
enclosing type-id is` `the type-id in an alias declaration` since C++20. Can
you show the rule name when you meet clang-tidy warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
