omerhadari commented on code in PR #15226:
URL: https://github.com/apache/iceberg/pull/15226#discussion_r2777729070
##########
core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java:
##########
@@ -159,6 +161,14 @@ public List<T> results() {
return Lists.newArrayList(committedRewrites.iterator());
}
+ /** Returns all File groups which failed to commit */
+ public List<T> failures() {
+ Preconditions.checkState(
+ committerService.isShutdown(),
+ "Cannot get failures from a service which has not been closed");
+ return Lists.newArrayList(failedRewrites.iterator());
+ }
Review Comment:
same exact wording as here in the same file
https://github.com/apache/iceberg/pull/15226/changes#diff-f048416da96d0fc04bbd5760809a16301c63cd838c27fbd1070efdbf3f29c704R160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
