nastra commented on code in PR #14859:
URL: https://github.com/apache/iceberg/pull/14859#discussion_r2787483152
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -297,11 +298,14 @@ private Result rebuildMetadata() {
rewriteManifests(deltaSnapshots, endMetadata,
rewriteManifestListResult.toRewrite());
// rebuild position delete files
+ // Use DeleteFileSet to deduplicate based on file location, content
offset, and content size.
+ // This is important for deletion vectors (DVs) where multiple entries can
reference the same
+ // Puffin file but have different offsets and sizes.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
