rdblue commented on code in PR #15111:
URL: https://github.com/apache/iceberg/pull/15111#discussion_r2823612623
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -107,7 +108,7 @@ public void deleteFile(String path) {
try {
deletePath(fs, toDelete, false);
} catch (IOException e) {
- throw new RuntimeIOException(e, "Failed to delete file: %s", path);
+ throw new RuntimeIOException(e, "Failed to delete file: %s: %s", path,
e.toString());
Review Comment:
The wrapped exception is passed as the cause so it is an anti-pattern to
show it as a string here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
