rdblue commented on code in PR #15111:
URL: https://github.com/apache/iceberg/pull/15111#discussion_r2823667144
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -214,14 +215,60 @@ private ExecutorService executorService() {
return executorService;
}
+ /**
+ * Is a path in a schema of a filesystem where the hadoop trash policy
should be used to move to
+ * it to trash?
+ *
+ * @param toDelete path to delete
+ * @return true if the path is in the list of schemas for which the
+ */
+ @VisibleForTesting
+ boolean isTrashSchema(Path toDelete) {
Review Comment:
Why isn't this a static field? I don't think we need to do string checking
every time delete is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
