mxm commented on code in PR #15312:
URL: https://github.com/apache/iceberg/pull/15312#discussion_r2873623657
##########
core/src/main/java/org/apache/iceberg/util/ThreadPools.java:
##########
@@ -44,6 +50,9 @@ private ThreadPools() {}
public static final int WORKER_THREAD_POOL_SIZE =
SystemConfigs.WORKER_THREAD_POOL_SIZE.value();
+ private static final ConcurrentLinkedDeque<ExecutorService>
THREAD_POOLS_TO_SHUTDOWN =
+ new ConcurrentLinkedDeque<>();
Review Comment:
I would prefer a simpler solution here with a simple
`List<ExecutorService>`. I don't think it hurts to synchronize on updates to
the list and on the shutdown logic. Let's make this simple. There is no need to
allow for multiple threads to issue the shutdown at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
