mxm commented on PR #15312: URL: https://github.com/apache/iceberg/pull/15312#issuecomment-3990934943
>I'm a bit wary of the nondeterministic state of this PR/task - esp with the new parallel PR out there :) would it be possible to have a think and set out a single list of changes pending before it can be considered complete/good enough? I understand that this feels uncertain, but as long as we discover open issues, we need to address them. It's a good idea to make a plan and update it over time. Both contributor and reviewer can do that. Let me try to formulate the acceptance criteria 1. Centrally manage all static thread pools and allow them to be shut down manually 2. Keep the existing behavior in place to shut down thread pools on JVM shutdown 3. Clean code and tests >also, what tests do you have in mind? There are several things we can test: - Verify static thread pools are registered - Verify shutdown works as intended - Verify shutdown hook gets added / removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
