moomindani opened a new pull request, #15557:
URL: https://github.com/apache/iceberg/pull/15557
## Description
Closes #13506
Replace the manual `File.createTempFile + delete` pattern with
`temp.resolve(...).toFile()` in `TestParquetVectorizedReads`, delegating temp
file cleanup to JUnit's `@TempDir` (already inherited from `AvroDataTestBase`).
**Before:**
```java
File testFile = File.createTempFile("junit", null, temp.toFile());
assertThat(testFile.delete()).as("Delete should succeed").isTrue();
```
**After:**
```java
File testFile = temp.resolve("junit.parquet").toFile();
```
Applied to Spark v3.5, v4.0, and v4.1 modules (5 occurrences each).
Note: A broader cleanup across all Spark test files was previously attempted
in #14095 but went stale. This PR intentionally limits scope to just
`TestParquetVectorizedReads` as originally described in the issue, to keep it
small and reviewable. Follow-up PRs can address the remaining files.
## Type of Change
- [ ] Bug fix
- [x] Improvement (non-breaking change)
- [ ] New feature
- [ ] Test improvement
## Checklist
- [x] Code follows the project's style guidelines
- [x] No new production code changed (test-only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
