ebyhr commented on code in PR #15557:
URL: https://github.com/apache/iceberg/pull/15557#discussion_r2904519810
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java:
##########
@@ -213,8 +213,7 @@ private void writeAndValidate(
Map<Integer, Object> idToConstant)
throws IOException {
// write a test parquet file using iceberg writer
- File testFile = File.createTempFile("junit", null, temp.toFile());
- assertThat(testFile.delete()).as("Delete should succeed").isTrue();
+ File testFile = temp.resolve("junit.parquet").toFile();
Review Comment:
nit: Since the test framework (JUnit) is unrelated to the test purpose and
the `temp` directory name already has the `junit-` prefix, we could rename it
to `data.parquet` or something similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
