moomindani opened a new pull request, #15558:
URL: https://github.com/apache/iceberg/pull/15558

   ## Summary
   
   `PropertyUtil.propertiesWithPrefix` used `String.replaceFirst(prefix, "")` 
to strip the prefix from matched keys. This treats the prefix as a **Java regex 
pattern**, so dots in the prefix (e.g. `"write.parquet.stats-enabled.column."`) 
are interpreted as regex wildcards. This is semantically incorrect — the intent 
is always to strip a literal prefix.
   
   The fix replaces `replaceFirst(prefix, "")` with 
`substring(prefix.length())`, which is safe, explicit, and consistent with the 
`startsWith(prefix)` filter applied immediately before.
   
   Also adds a regression test for the multi-column statistics disable use case 
reported in #15347, verifying that:
   - disabling `write.parquet.stats-enabled.column.*` for multiple columns 
correctly disables stats for all specified columns, and
   - unspecified columns are unaffected.
   
   Note: PR #15553 addresses the same issue with a test-only change; this PR 
additionally includes the root-cause fix in `PropertyUtil`.
   
   Fixes #15347
   
   ## Test plan
   
   - [x] `TestParquet#testMultipleColumnsStatisticsDisabled` — new test 
covering the multi-column case
   - [x] `TestParquet#testColumnStatisticsEnabled` — existing mixed true/false 
test still passes
   - [x] `TestPropertyUtil` — existing `PropertyUtil` tests still pass
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to