RussellSpitzer commented on code in PR #15652:
URL: https://github.com/apache/iceberg/pull/15652#discussion_r2941238378
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -625,6 +628,24 @@ protected RollingManifestWriter<DeleteFile>
newRollingDeleteManifestWriter(Parti
() -> newDeleteManifestWriter(spec), targetManifestSizeBytes);
}
+ private static Map<String, String> manifestWriterProperties(TableMetadata
metadata) {
+ ImmutableMap.Builder<String, String> builder = ImmutableMap.builder();
+
+ String codec =
+ metadata.property(
+ TableProperties.AVRO_COMPRESSION,
TableProperties.AVRO_COMPRESSION_DEFAULT);
Review Comment:
Could be, we currently have these properties
Property | Default
-- | --
write.avro.compression-codec | gzip
write.delete.avro.compression-codec | (same)
write.avro.compression-level | null
write.delete.avro.compression-level | null
You think we should just add another
write.avro.manifest.compression-codec
or leave it format independent since we may have a
write.manifest.format
and then
write.manifest.compression-codec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
