danielcweeks commented on code in PR #15652:
URL: https://github.com/apache/iceberg/pull/15652#discussion_r2941948684
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -625,6 +628,24 @@ protected RollingManifestWriter<DeleteFile>
newRollingDeleteManifestWriter(Parti
() -> newDeleteManifestWriter(spec), targetManifestSizeBytes);
}
+ private static Map<String, String> manifestWriterProperties(TableMetadata
metadata) {
+ ImmutableMap.Builder<String, String> builder = ImmutableMap.builder();
+
+ String codec =
+ metadata.property(
+ TableProperties.AVRO_COMPRESSION,
TableProperties.AVRO_COMPRESSION_DEFAULT);
Review Comment:
I'm a little concerned that we're using the data file default for metadata.
Why wouldn't we introduce a separate metadata compression and level that
applies to all metadata files? Do we need to be format specific about this
anyway? Seems like we could just have a single config and pass that through to
the writers regardless (the codecs are generally supported across all the
formats, I believe)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
