pvary commented on code in PR #15652:
URL: https://github.com/apache/iceberg/pull/15652#discussion_r2944860568
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -211,6 +212,25 @@ public static ManifestWriter<DataFile> write(
return newWriter(formatVersion, spec, encryptedOutputFile, snapshotId,
null);
}
+ /**
+ * Create a new {@link ManifestWriter} for the given format version with
custom writer properties.
+ *
+ * @param formatVersion a target format version
+ * @param spec a {@link PartitionSpec}
+ * @param encryptedOutputFile an {@link EncryptedOutputFile} where the
manifest will be written
+ * @param snapshotId a snapshot ID for the manifest entries, or null for an
inherited ID
+ * @param writerProperties properties passed through to the underlying file
writer
+ * @return a manifest writer
+ */
+ public static ManifestWriter<DataFile> write(
Review Comment:
Really just a question. Do we want to keep all of the `write` versions?
Shall we deprecate the old ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
