sfc-gh-rspitzer commented on code in PR #15150:
URL: https://github.com/apache/iceberg/pull/15150#discussion_r2957372929
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -171,6 +172,26 @@ public int outputSpecId() {
return outputSpecId;
}
+ public int outputSortOrderId(SparkWriteRequirements writeRequirements) {
+ String explicitId =
+
confParser.stringConf().option(SparkWriteOptions.OUTPUT_SORT_ORDER_ID).parseOptional();
+
+ if (explicitId != null) {
+ int id = Integer.parseInt(explicitId);
+ Preconditions.checkArgument(
+ table.sortOrders().containsKey(id),
+ "Output sort order id %s is not a valid sort order id for table",
Review Comment:
nit: we do "Cannot x because y (optionally fix z)"
So "Cannot use output sort order id %d because the table does not contain a
sort order with that id"
or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
