RussellSpitzer commented on code in PR #15150:
URL: https://github.com/apache/iceberg/pull/15150#discussion_r2957408799
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/TestSparkWriteConf.java:
##########
@@ -606,6 +607,42 @@ public void testDVWriteConf() {
assertThat(writeConf.deleteFileFormat()).isEqualTo(FileFormat.PUFFIN);
}
+ @TestTemplate
+ public void testSortOrderWriteConf() {
+ Table table = validationCatalog.loadTable(tableIdent);
+
+ table.replaceSortOrder().asc("id").commit();
+
+ SparkWriteConf writeConf =
+ new SparkWriteConf(
+ spark,
+ table,
+ new CaseInsensitiveStringMap(
+ ImmutableMap.of(SparkWriteOptions.OUTPUT_SORT_ORDER_ID, "1")));
+
+ assertThat(writeConf.outputSortOrderId(SparkWriteRequirements.EMPTY))
+ .isEqualTo(table.sortOrder().orderId());
+
+ SparkWriteConf writeConfForUnknownSortOrder =
+ new SparkWriteConf(
+ spark,
+ table,
+ new CaseInsensitiveStringMap(
+ ImmutableMap.of(SparkWriteOptions.OUTPUT_SORT_ORDER_ID,
"999")));
+
+ assertThatIllegalArgumentException()
+ .isThrownBy(
+ () ->
writeConfForUnknownSortOrder.outputSortOrderId(SparkWriteRequirements.EMPTY))
+ .withMessage("Output sort order id 999 is not a valid sort order id
for table");
+
+ SparkWriteConf writeConfNoOption = new SparkWriteConf(spark, table);
Review Comment:
Same for here, may as well be another test, I don't think we are saving much
in setup duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
