ebyhr commented on code in PR #15681:
URL: https://github.com/apache/iceberg/pull/15681#discussion_r2957801479


##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteRequirements.java:
##########
@@ -26,8 +26,10 @@
 /** A set of requirements such as distribution and ordering reported to Spark 
during writes. */
 public class SparkWriteRequirements {
 
+  public static final long NO_ADVISORY_PARTITION_SIZE = 0;

Review Comment:
   Is there a reason this constant needs to be public? Could we make it private 
for now and only relax the visibility if a concrete use case comes up?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to