RussellSpitzer commented on code in PR #15681:
URL: https://github.com/apache/iceberg/pull/15681#discussion_r2961360595
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteRequirements.java:
##########
@@ -54,6 +56,8 @@ public boolean hasOrdering() {
public long advisoryPartitionSize() {
// Spark prohibits requesting a particular advisory partition size without
distribution
- return distribution instanceof UnspecifiedDistribution ? 0 :
advisoryPartitionSize;
+ return distribution instanceof UnspecifiedDistribution
Review Comment:
I liked how you moved this into SparkWriteRequirements constructor in the
previous pr, I think it's weird that the class stores a value and then ignores
it sometimes. We are currently basically saying "hey you can pass in a value,
jk it does nothing because a different parameter was passed.
It would probably make sense to prohibit specifying advisory size if
distribution is "unspecified" but I think that may break some things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
