YanivZalach commented on PR #15706: URL: https://github.com/apache/iceberg/pull/15706#issuecomment-4102942233
I agree that option 2 (fail with a clear error) is the right tradeoff here. The name `ICEZVALUE` is unlikely to conflict in practice, but when it does, the current behavior is silent data modification, followed by a completely misleading error that gives the user no indication of what went wrong or how to fix it, and when a rewrite did not happen because of the thresholds, no error at all. The value of this PR is not preventing a common case — it's making a rare but confusing failure mode diagnosable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
