wypoon commented on PR #15706: URL: https://github.com/apache/iceberg/pull/15706#issuecomment-4112497886
I agree that making the column name be configurable is overkill, that the complexity is not worth it. I think that 1 would be best (no user intervention needed, we hide the problem). In fact, generating a random name was my first thought. I agree that a table having "ICEZVALUE" as a column name is unlikely. @YanivZalach did you discover the problem because you were perusing the code and came upon this hardcoded name, or did you have a table with that column name and ran into the problem? Unlikely as "ICEZVALUE" may be as a column name, I'd suggest as an improvement, to use a name as @RussellSpitzer suggested, gen_zorder_xx with a randomized xx, which will almost certainly never be a column in an actual table. Then just do the precondition check, but with no need to change the randomized name if there is a match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
