RussellSpitzer commented on code in PR #15500:
URL: https://github.com/apache/iceberg/pull/15500#discussion_r2989644939
##########
core/src/main/java/org/apache/iceberg/rest/auth/TLSConfigurer.java:
##########
@@ -32,6 +33,10 @@ default SSLContext sslContext() {
return SSLContexts.createDefault();
}
+ default HostnameVerificationPolicy hostnameVerificationPolicy() {
Review Comment:
I wrote on the ML list a bit about this, but do we really need this to be
customizable?
It seems to be that there are only really 2 options that make sense.
Either
`hostnameVerifier` is replaced and we should use "client" mode
or
`hostnameVerifier" is not replaced and we should be using "builtin" mode
##########
core/src/main/java/org/apache/iceberg/rest/auth/TLSConfigurer.java:
##########
@@ -32,6 +33,10 @@ default SSLContext sslContext() {
return SSLContexts.createDefault();
}
+ default HostnameVerificationPolicy hostnameVerificationPolicy() {
Review Comment:
I wrote on the ML list a bit about this, but do we really need this to be
customizable?
It seems to be that there are only really 2 options that make sense.
Either
`hostnameVerifier` is replaced and we should use "client" mode
or
`hostnameVerifier` is not replaced and we should be using "builtin" mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
