stevenzwu commented on code in PR #15500:
URL: https://github.com/apache/iceberg/pull/15500#discussion_r2996653530
##########
core/src/main/java/org/apache/iceberg/rest/auth/TLSConfigurer.java:
##########
@@ -32,6 +33,10 @@ default SSLContext sslContext() {
return SSLContexts.createDefault();
}
+ default HostnameVerificationPolicy hostnameVerificationPolicy() {
+ return HostnameVerificationPolicy.CLIENT;
+ }
+
default HostnameVerifier hostnameVerifier() {
Review Comment:
@RussellSpitzer @adutra this is the method where I suggested adding Javadoc.
or you think this is redundant and the intention is obvious from the API
already?
```
/**
* If overwritten, only the custom verifier is executed and
* Java Secure Socket Extension (JSSE) built-in verifier won't be executed.
*/
```
I also like Russell's suggestion from email of making this method returning
null so that we can get rid of the new method above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
