kevinjqliu commented on code in PR #15800: URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003646064
########## site/docs/benchmarks.md: ########## @@ -28,6 +28,8 @@ Also note that JMH benchmarks run within the same JVM as the system-under-test, It is possible to run one or more Benchmarks via the **JMH Benchmarks** GH action on your own fork of the Iceberg repo. This GH action takes the following inputs: * The repository name where those benchmarks should be run against, such as `apache/iceberg` or `<user>/iceberg` * The branch name to run benchmarks against, such as `main` or `my-cool-feature-branch` +* The Spark version to use, such as `3.5` (default: `3.5`) +* The Scala version to use, such as `2.12` (default: `2.12`) Review Comment: good catch, done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
