ebyhr commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003671155
##########
.github/workflows/recurring-jmh-benchmarks.yml:
##########
@@ -68,7 +68,7 @@ jobs:
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' |
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- name: Run Benchmark
- run: ./gradlew :iceberg-spark:${{ matrix.spark_version }}:jmh
-PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{
matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark
}}.json
+ run: ./gradlew -DsparkVersions=${{ matrix.spark }} -DscalaVersion=${{
matrix.scala }} :iceberg-spark:iceberg-spark-${{ matrix.spark }}_${{
matrix.scala }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }}
-PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt
-PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
Review Comment:
I sent a similar PR #15729 a few days ago and noticed the
`actions/upload-artifact` below fails with the conflicted artifact name. My PR
added another step to change the artifact name. Does this PR work without such
changes?
I'll close my PR. Please feel to copy the change if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
