geserdugarov opened a new pull request, #2294: URL: https://github.com/apache/iceberg-rust/pull/2294
## Which issue does this PR close? - Closes #352. ## What changes are included in this PR? Changes `snapshot_id` from `Option<i64>` to `i64` in `ManifestWriterBuilder::new` and `ManifestWriter::new` - enforcing at the type level that callers must provide a real snapshot ID. Updates all callers. Preserves the deserialization path, EMPTY_SNAPSHOT_ID is kept solely for normalizing legacy -1 values to None when reading old metadata. ## Are these changes tested? Adds a test `test_empty_snapshot_id_is_normalized_to_none` verifying the deserialization normalization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
