geserdugarov commented on code in PR #2294:
URL: https://github.com/apache/iceberg-rust/pull/2294#discussion_r3008914583
##########
crates/iceberg/src/spec/manifest/writer.rs:
##########
@@ -32,14 +32,14 @@ use crate::spec::manifest::_serde::{ManifestEntryV1,
ManifestEntryV2};
use crate::spec::manifest::{manifest_schema_v1, manifest_schema_v2};
use crate::spec::{
DataContentType, DataFile, FieldSummary, ManifestEntry, ManifestFile,
ManifestMetadata,
- ManifestStatus, PrimitiveLiteral, SchemaRef, StructType,
UNASSIGNED_SNAPSHOT_ID,
+ ManifestStatus, PrimitiveLiteral, SchemaRef, StructType,
};
use crate::{Error, ErrorKind};
/// The builder used to create a [`ManifestWriter`].
pub struct ManifestWriterBuilder {
output: OutputFile,
- snapshot_id: Option<i64>,
+ snapshot_id: i64,
Review Comment:
Thanks for review, @blackmwk
My bad. I've reverted these changes. But I have to change commit message, so
force pushed to 172a3d08dd2d50b4ba86b6b137ffdb04c3904264
##########
crates/iceberg/src/spec/manifest/writer.rs:
##########
@@ -160,7 +160,7 @@ impl ManifestWriterBuilder {
pub struct ManifestWriter {
output: OutputFile,
- snapshot_id: Option<i64>,
+ snapshot_id: i64,
Review Comment:
Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
