RussellSpitzer commented on code in PR #10837:
URL: https://github.com/apache/iceberg/pull/10837#discussion_r3011565629


##########
spark/v3.4/spark-extensions/src/jmh/java/org/apache/iceberg/spark/MergeCardinalityCheckBenchmark.java:
##########
@@ -155,7 +155,7 @@ private void runBenchmark(RowLevelOperationMode mode, 
double updatePercentage) {
   private void setupSpark() {
     this.spark =
         SparkSession.builder()
-            .config("spark.ui.enabled", false)
+            .config(TestBase.DISABLE_UI)

Review Comment:
   Does this mean it's going to be an issue for downstream users? If not why 
don't we switch these benchmarks to use the fat jar?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to